Skip to content

chore: changes moby/stairway#564

Open
titouantanguy wants to merge 64 commits into
mainfrom
titouan/chore/minor-nist-bench
Open

chore: changes moby/stairway#564
titouantanguy wants to merge 64 commits into
mainfrom
titouan/chore/minor-nist-bench

Conversation

@titouantanguy
Copy link
Copy Markdown
Contributor

@titouantanguy titouantanguy commented May 4, 2026

Description of changes

Ended up not being a minor change.

Sets up the all-in-one script for BGV and TFHE-rs (testparams) KAT + bench required by NIST submission + export to csv format expected by latex doc.
Meant to run on the baseline platform.

Issue ticket number and link

PR Checklist

I attest that all checked items are satisfied. Any deviation is clearly justified above.

  • Title follows conventional commits (e.g. chore: ...).
  • Tests added for every new pub item and test coverage has not decreased.
  • Public APIs and non-obvious logic documented; unfinished work marked as TODO(#issue).
  • unwrap/expect/panic only in tests or for invariant bugs (documented if present).
  • No dependency version changes OR (if changed) only minimal required fixes.
  • No architectural protocol changes OR linked spec PR/issue provided.
  • No breaking deployment config changes OR devops label + infra notified + infra-team reviewer assigned.
  • No breaking gRPC / serialized data changes OR commit marked with ! and affected teams notified.
  • No modifications to existing versionized structs OR backward compatibility tests updated.
  • No critical business logic / crypto changes OR ≥2 reviewers assigned.
  • No new sensitive data fields added OR Zeroize + ZeroizeOnDrop implemented.
  • No new public storage data OR data is verifiable (signature / digest).
  • No unsafe; if unavoidable: minimal, justified, documented, and test/fuzz covered.
  • Strongly typed boundaries: typed inputs validated at the edge; no untyped values or errors cross modules.
  • Self-review completed.

Dependency Update Questionnaire (only if deps changed or added)

Answer in the Cargo.toml next to the dependency (or here if updating):

  1. Ownership changes or suspicious concentration?
  2. Low popularity?
  3. Unusual version jump?
  4. Lacking documentation?
  5. Missing CI?
  6. No security / disclosure policy?
  7. Significant size increase?

More details and explanations for the checklist and dependency updates can be found in CONTRIBUTING.md

@cla-bot cla-bot Bot added the cla-signed The CLA has been signed. label May 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Consolidated Tests Results 2026-05-20 - 13:23:53

Test Results

passed 7 passed

Details

tests 7 tests
clock not captured
tool junit-to-ctrf
build build-and-test arrow-right test-reporter link #2275
pull-request chore: changes moby/stairway link #564

test-reporter: Run #2275

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
7 7 0 0 0 0 0 not captured

🎉 All tests passed!

Tests

View All Tests
Test Name Status Flaky Duration
k8s_test_crs_uniqueness 39.3s
k8s_test_insecure_keygen_encrypt_and_public_decrypt 1m 49s
k8s_test_insecure_keygen_encrypt_multiple_types 2m 2s
k8s_test_keygen_and_crs 1m 56s
k8s_test_keygen_uniqueness 4m 40s
k8s_test_centralized_insecure 1m 1s
nightly_full_gen_tests_default_k8s_centralized_sequential_crs 1.8s

🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@titouantanguy titouantanguy marked this pull request as ready for review May 5, 2026 11:15
@titouantanguy titouantanguy requested a review from a team as a code owner May 5, 2026 11:15
@titouantanguy titouantanguy force-pushed the titouan/chore/minor-nist-bench branch from 9469e5d to 6b32d44 Compare May 5, 2026 11:15
Comment thread docs/guides/threshold-benchmark.md Outdated
Comment thread docs/guides/threshold-benchmark.md Outdated
Comment thread docs/guides/threshold-benchmark.md
Comment thread docs/guides/threshold-benchmark.md
dvdplm
dvdplm previously approved these changes May 18, 2026
Copy link
Copy Markdown
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, modulo some typos

Comment thread core/experiments/NIST_scripts/threshold-test-params.sh Outdated
Comment thread core/experiments/src/bin/threshold-bgv/stairwayctl.rs Outdated
Comment thread core/experiments/src/bin/threshold-bgv/stairwayctl.rs Outdated
Comment thread core/experiments/src/bin/threshold-bgv/stairwayctl.rs
Comment thread core/experiments/src/choreography/tfhe_rs/grpc.rs Outdated
Comment thread docs/guides/threshold-benchmark.md Outdated
Comment thread docs/guides/threshold-benchmark.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants